Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Make dynamically created Headline static#389

Merged
dremartins merged 1 commit intoZEISS:mainfrom
shirk33y:static-headline
Dec 8, 2022
Merged

Make dynamically created Headline static#389
dremartins merged 1 commit intoZEISS:mainfrom
shirk33y:static-headline

Conversation

@shirk33y
Copy link
Copy Markdown
Contributor

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

This change defines all heading components statically (in the moment of import) in order to get rid of this warning in console:

image

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 30, 2022

CLA assistant check
All committers have signed the CLA.

@shirk33y
Copy link
Copy Markdown
Contributor Author

To be sure, I made side by side screenshot

image

dremartins
dremartins previously approved these changes Dec 5, 2022
@dremartins dremartins merged commit d5de0f5 into ZEISS:main Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants