This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: make some component types compatible with react 18#383
Merged
dremartins merged 3 commits intoZEISS:mainfrom Nov 15, 2022
Merged
feat: make some component types compatible with react 18#383dremartins merged 3 commits intoZEISS:mainfrom
dremartins merged 3 commits intoZEISS:mainfrom
Conversation
shirk33y
previously approved these changes
Nov 15, 2022
dremartins
reviewed
Nov 15, 2022
dremartins
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Please make sure you can check the following two boxes:
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
We are using precise-ui in a react 18 project. Since react 18,
React.FCdoesn't have thechildrenprop anymore. Therefore, we get a Typescript error as soon as we add a child to a component that usesReact.FC.In order to keep the change minimal, I did 2 things:
ReactComponentDefaultPropsthat can be used to extend property types forReact.Component.ReactFCinterface, that can be used as a drop-in replacement forReact.FCI didn't replace all
React.FCcomponents withReactFC, but only the ones we need right now to keep the change minimal.