Moon hint fix, patch creation tweaks#141
Merged
PhlexPlexico merged 2 commits intoZ3DR:mainfrom Feb 4, 2026
Merged
Conversation
- Reduce duplicated code from RegionSelect - Don't create useless "actor" folder - Cleanup commented section titles
When writing a moon trial gossip stone's hint, write it again to its alternate message's ID. This ensures the same hint is displayed when the game calls either version.
|
LGTM - just as a heads up though, if you're going to be making changes to different parts I would still recommend breaking out your changes into separate merges. E.g. even though it's small have the moon text fix in a separate PR from the cleanup that was done in patches (and I know, the codebase could definitely use a good reformat/refactor, so feel free to follow the Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix moon trial hints sometimes not displaying
Cleans up patch.cpp (by copying OOT3DR's homework)