Closed
Conversation
Performance is the same for most of the Redis examples, but much faster for
multibulk. GHC perhaps optimizes it better when used in non-inlined functions.
* Before:
benchmarking multi/Scanner
time 556.1 ns (538.6 ns .. 582.3 ns)
0.989 R² (0.982 R² .. 0.995 R²)
mean 560.5 ns (544.6 ns .. 577.8 ns)
std dev 57.16 ns (44.10 ns .. 73.20 ns)
variance introduced by outliers: 90% (severely inflated)
* After:
benchmarking multi/Scanner
time 374.0 ns (370.4 ns .. 377.8 ns)
0.999 R² (0.998 R² .. 0.999 R²)
mean 375.7 ns (370.9 ns .. 380.6 ns)
std dev 16.45 ns (13.53 ns .. 20.47 ns)
variance introduced by outliers: 62% (severely inflated)
Owner
|
Good catch, thank you! Merged as 19c6649 (it required rebase) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance is the same for most of the Redis examples, but much faster for
multibulk. GHC perhaps optimizes it better when used in non-inlined functions.
benchmarking multi/Scanner
time 556.1 ns (538.6 ns .. 582.3 ns)
0.989 R² (0.982 R² .. 0.995 R²)
mean 560.5 ns (544.6 ns .. 577.8 ns)
std dev 57.16 ns (44.10 ns .. 73.20 ns)
variance introduced by outliers: 90% (severely inflated)
benchmarking multi/Scanner
time 374.0 ns (370.4 ns .. 377.8 ns)
0.999 R² (0.998 R² .. 0.999 R²)
mean 375.7 ns (370.9 ns .. 380.6 ns)
std dev 16.45 ns (13.53 ns .. 20.47 ns)
variance introduced by outliers: 62% (severely inflated)