Skip to content

chore: migrate to folke/github reusable workflows#99

Merged
YousefHadder merged 4 commits intomainfrom
chore/migrate-to-folke-workflows
Nov 2, 2025
Merged

chore: migrate to folke/github reusable workflows#99
YousefHadder merged 4 commits intomainfrom
chore/migrate-to-folke-workflows

Conversation

@YousefHadder
Copy link
Copy Markdown
Owner

🔄 Migrate to folke/github Reusable Workflows

This PR migrates our CI/CD workflows to use folke/github reusable workflows, standardizing our setup with other popular Neovim plugins.

Changes

Removed (280 lines)

  • tests.yml → Replaced by folke CI
  • commitlint.yml → Replaced by pr.yml
  • release-please.yml → Now handled by folke CI

Added (122 lines)

  • ci.yml → Calls folke's reusable CI workflow (tests, lint, format, release-please)
  • pr.yml → PR title validation (conventional commits)
  • post-release.yml → Creates rockspec PRs after releases
  • scripts/test → Test script for CI auto-detection
  • make check → Run all CI checks locally

Kept Unchanged

  • release-to-luarocks.yml → LuaRocks publishing
  • security-scan.yml → Security scanning

Benefits

Simpler: 158 fewer lines of workflow code (-58%)
Standardized: Uses folke's battle-tested CI patterns
Maintained: CI updates happen upstream
Complete: All features preserved (tests, lint, format, releases, rockspecs, LuaRocks)
Testable: make check runs same checks as CI

What folke CI Provides

  1. Stylua formatting checks
  2. Tests via scripts/test
  3. Debug detection (catches dd() calls)
  4. Release automation via release-please
  5. PR title validation (conventional commits)

Release Flow

Push to main
   ↓
folke CI: tests + lint + format
   ↓
folke CI: release-please (auto PR)
   ↓
Merge release PR → GitHub Release published
   ↓
post-release.yml: Create rockspec PR
   ↓
Auto-merge rockspec PR
   ↓
release-to-luarocks.yml: Publish to LuaRocks

Testing

All workflows have been validated and the test script works correctly:

./scripts/test  # ✅ All tests pass
make check      # ✅ Lint, format-check, test

Copilot AI review requested due to automatic review settings November 2, 2025 19:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the CI/CD infrastructure from custom GitHub Actions workflows to use folke/github's reusable workflow system, significantly simplifying the project's CI setup.

Key changes:

  • Replaces custom test/lint/format workflows with folke/github's unified CI workflow
  • Replaces custom commitlint workflow with folke/github's PR title validation workflow
  • Splits the monolithic release-please workflow into a simplified post-release workflow
  • Adds a scripts/test entry point and make check target to support the new CI system

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/ci.yml New unified CI workflow delegating to folke/github's reusable workflow
.github/workflows/pr.yml New PR title validation workflow using folke/github
.github/workflows/post-release.yml Simplified post-release workflow for rockspec creation after releases
.github/workflows/tests.yml Removed custom test/lint/format workflows (replaced by ci.yml)
.github/workflows/release-please.yml Removed (release creation still handled by release-please, post-release tasks moved)
.github/workflows/commitlint.yml Removed (replaced by pr.yml)
scripts/test New test entry point script for folke/github CI integration
Makefile Added check target combining lint, format-check, and test for CI

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 2, 2025 19:47
@YousefHadder YousefHadder merged commit 15240bf into main Nov 2, 2025
17 checks passed
@YousefHadder YousefHadder deleted the chore/migrate-to-folke-workflows branch November 2, 2025 19:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants