chore: migrate to folke/github reusable workflows#99
Merged
YousefHadder merged 4 commits intomainfrom Nov 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the CI/CD infrastructure from custom GitHub Actions workflows to use folke/github's reusable workflow system, significantly simplifying the project's CI setup.
Key changes:
- Replaces custom test/lint/format workflows with folke/github's unified CI workflow
- Replaces custom commitlint workflow with folke/github's PR title validation workflow
- Splits the monolithic release-please workflow into a simplified post-release workflow
- Adds a
scripts/testentry point andmake checktarget to support the new CI system
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci.yml | New unified CI workflow delegating to folke/github's reusable workflow |
| .github/workflows/pr.yml | New PR title validation workflow using folke/github |
| .github/workflows/post-release.yml | Simplified post-release workflow for rockspec creation after releases |
| .github/workflows/tests.yml | Removed custom test/lint/format workflows (replaced by ci.yml) |
| .github/workflows/release-please.yml | Removed (release creation still handled by release-please, post-release tasks moved) |
| .github/workflows/commitlint.yml | Removed (replaced by pr.yml) |
| scripts/test | New test entry point script for folke/github CI integration |
| Makefile | Added check target combining lint, format-check, and test for CI |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔄 Migrate to folke/github Reusable Workflows
This PR migrates our CI/CD workflows to use folke/github reusable workflows, standardizing our setup with other popular Neovim plugins.
Changes
Removed (280 lines)
tests.yml→ Replaced by folke CIcommitlint.yml→ Replaced bypr.ymlrelease-please.yml→ Now handled by folke CIAdded (122 lines)
ci.yml→ Calls folke's reusable CI workflow (tests, lint, format, release-please)pr.yml→ PR title validation (conventional commits)post-release.yml→ Creates rockspec PRs after releasesscripts/test→ Test script for CI auto-detectionmake check→ Run all CI checks locallyKept Unchanged
release-to-luarocks.yml→ LuaRocks publishingsecurity-scan.yml→ Security scanningBenefits
✅ Simpler: 158 fewer lines of workflow code (-58%)
✅ Standardized: Uses folke's battle-tested CI patterns
✅ Maintained: CI updates happen upstream
✅ Complete: All features preserved (tests, lint, format, releases, rockspecs, LuaRocks)
✅ Testable:
make checkruns same checks as CIWhat folke CI Provides
scripts/testdd()calls)Release Flow
Testing
All workflows have been validated and the test script works correctly: