feat(table): add insert mode cell navigation with Alt+hjkl#98
Merged
YousefHadder merged 2 commits intomainfrom Nov 2, 2025
Merged
feat(table): add insert mode cell navigation with Alt+hjkl#98YousefHadder merged 2 commits intomainfrom
YousefHadder merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds insert mode navigation for markdown tables, allowing users to move between cells using Alt+hjkl keys with circular wrapping behavior. When not in a table, the keys fall back to standard arrow key behavior.
Key changes:
- Adds four new navigation functions (
move_left,move_right,move_up,move_down) with wrapping logic - Introduces configurable insert mode keymaps (Alt+hjkl) with arrow key fallback
- Comprehensive test coverage for all navigation directions and edge cases
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lua/markdown-plus/types.lua | Adds insert_mode_navigation boolean config field to table keymaps |
| lua/markdown-plus/table/navigation.lua | Implements four navigation functions with wrapping logic and separator row handling |
| lua/markdown-plus/table/init.lua | Exposes navigation functions through the table module API |
| lua/markdown-plus/table/keymaps.lua | Sets up Alt+hjkl insert mode keymaps with arrow key fallback when not in table |
| spec/markdown-plus/table_spec.lua | Adds comprehensive tests for all navigation directions, wrapping, and edge cases |
| doc/markdown-plus.txt | Documents insert mode navigation feature, keymaps, and wrapping behavior |
| README.md | Documents insert mode navigation with examples and wrapping behavior |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 4-directional table cell navigation in insert mode using Alt+hjkl keymaps with circular wrapping behavior. Navigation wraps from last to first cell in both rows and columns for seamless editing experience.