fix(jumplist): add jump list entries for footnote navigation#148
Merged
YousefHadder merged 1 commit intomainfrom Nov 30, 2025
Merged
fix(jumplist): add jump list entries for footnote navigation#148YousefHadder merged 1 commit intomainfrom
YousefHadder merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances footnote navigation by adding jump list entries before cursor movements, enabling users to return to their original position using <C-o> after navigating to footnote definitions or references.
Key Changes:
- Added
vim.cmd("normal! m'")before all cursor movement operations in footnote navigation and insertion functions - Ensures consistent behavior across
goto_definition,goto_reference, andinsert_footnotefunctions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lua/markdown-plus/footnotes/navigation.lua |
Added jump list entries before cursor movements in goto_definition (line 43) and goto_reference functions (lines 70, 99) |
lua/markdown-plus/footnotes/insertion.lua |
Added jump list entry before cursor movement to definition in insert_footnote function (line 157) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #145
Adds
m'before cursor movements in footnote insertion and navigation so<C-o>correctly returns to the original position.