fix(footnotes): add nil check in goto_definition navigation#208
Merged
YousefHadder merged 5 commits intomainfrom Feb 8, 2026
Merged
fix(footnotes): add nil check in goto_definition navigation#208YousefHadder merged 5 commits intomainfrom
YousefHadder merged 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a defensive guard in the footnotes navigation flow to avoid a crash when nvim_buf_get_lines() returns no line (e.g., after buffer changes), improving the robustness of goto_definition() in the footnotes feature.
Changes:
- Add a nil check for the fetched definition line before calling
line:find() - Add a fallback cursor jump to column 0 when the definition line cannot be read
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a defensive nil check in
footnotes/navigation.luagoto_definition()afternvim_buf_get_lines().If the buffer changes between parsing and cursor movement (e.g., via autocmd or async operation),
linecould be nil causing a crash on the subsequentline:find()call. The nil guard falls back to jumping to column 0 of the definition line.