fix(format): strip same-type inner formatting when toggling on visual selection#166
Merged
YousefHadder merged 4 commits intomainfrom Dec 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #165 by implementing Obsidian/Typora-like behavior when toggling formatting on visual selections that contain existing same-type formatting. When applying bold to "hello world", the plugin now strips the inner bold markers before wrapping, resulting in "hello world" instead of "hello world".
Key Changes
- Added
contains_formatting()function to detect formatting anywhere within text (not just wrapping) - Added
strip_format_type()function to remove all instances of a specific format type while preserving other formatting - Modified
toggle_format()to strip same-type inner formatting before wrapping selections
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
lua/markdown-plus/format/init.lua |
Implements two new helper functions (contains_formatting and strip_format_type) and modifies toggle_format to strip same-type formatting before wrapping visual selections |
spec/markdown-plus/format_spec.lua |
Adds comprehensive test coverage for the new helper functions and integration tests verifying the new toggle behavior with various format types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before:
hello **world**+ select all + toggle bold →**hello **world****After:
hello **world**+ select all + toggle bold →**hello world**Closes #165
Testing
Checklist