feat(format): add highlight and underline support#156
Merged
YousefHadder merged 2 commits intomainfrom Dec 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for two extended Markdown formatting styles: highlight (==text==) and underline (++text++), commonly used in editors like Obsidian and Typora but not part of standard GitHub Flavored Markdown.
Key Changes:
- Added pattern definitions and formatting logic for highlight and underline
- Implemented keymaps
<leader>mh(highlight) and<leader>mu(underline) following existing conventions - Added comprehensive test coverage for both new formatting types
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lua/markdown-plus/format/init.lua | Added pattern definitions for highlight/underline, implemented keymaps, updated word boundary detection to include = and + characters, and updated clear_formatting functions to handle new formats |
| spec/markdown-plus/format_spec.lua | Added comprehensive unit tests for detecting, adding, and removing highlight and underline formatting, plus pattern verification tests |
| doc/markdown-plus.txt | Documented the new formatting features with usage examples, keymaps, compatibility notes explaining platform support differences, and updated API reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for highlight (==) and underline (++) formatting.
Includes:
lua/markdown-plus/format/init.luaspec/markdown-plus/format_spec.luadoc/markdown-plus.txt(fixed vimdoc formatting)