Skip to content

BrainMonkey/TestCase: add new makeDouble[s]ForUnavailableClass[es]() functions#40

Merged
jrfnl merged 1 commit intodevelopfrom
feature/add-test-dummy-class
Nov 16, 2022
Merged

BrainMonkey/TestCase: add new makeDouble[s]ForUnavailableClass[es]() functions#40
jrfnl merged 1 commit intodevelopfrom
feature/add-test-dummy-class

Conversation

@jrfnl
Copy link
Copy Markdown
Collaborator

@jrfnl jrfnl commented Nov 16, 2022

These methods allow for on the fly creation of test doubles which allow for dynamic properties, which allows for bypassing the PHP 8.2 dynamic property deprecation notice when the real class has these properties declared, but a mock is used in the tests.

See the README docs + mockery/mockery#1197 for additional information.

Includes:

  • Tests to cover the new functionality.
  • Documentation in the README file.

@jrfnl jrfnl added enhancement New feature or request yoastcs/qa labels Nov 16, 2022
@jrfnl jrfnl added this to the 1.x Next Release milestone Nov 16, 2022
@jrfnl jrfnl force-pushed the feature/add-test-dummy-class branch 2 times, most recently from db3b408 to ae037ce Compare November 16, 2022 16:40
…` functions

These methods allow for on the fly creation of test doubles which allow for dynamic properties, which allows for bypassing the PHP 8.2 dynamic property deprecation notice when the _real_ class has these properties declared, but a mock is used in the tests.

See the README docs + mockery/mockery 1197 for additional information.

Includes:
* Tests to cover the new functionality.
* Documentation in the README file.
@jrfnl jrfnl force-pushed the feature/add-test-dummy-class branch from ae037ce to b4e655f Compare November 16, 2022 16:52
@jrfnl jrfnl merged commit 54c2ec2 into develop Nov 16, 2022
@jrfnl jrfnl deleted the feature/add-test-dummy-class branch November 16, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request yoastcs/qa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant