Conversation
…setup As the WP-CLI `scaffold` command is an often-used basis for setting up the integration tests, this commit adds a native check to WP Test Utils in the integration tests `get_path_to_wp_test_dir()` function for the WP native test bootstrap in the typical location used by the WP-CLI `scaffold` `install-wp-tests.sh` script. This means that if the `install-wp-tests.sh` script is used without adjustments, the path to the WP native test bootstrap should be findable by WP Test Utils without needing to set the `WP_TESTS_DIR` constant. Fixes 12
swissspidy
approved these changes
Sep 23, 2021
swissspidy
left a comment
There was a problem hiding this comment.
Works well in my testing! 👍
Many thanks!
Collaborator
Author
|
Thanks for testing this @swissspidy ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the WP-CLI
scaffoldcommand is an often-used basis for setting up the integration tests, this commit adds a native check to WP Test Utils in the integration testsget_path_to_wp_test_dir()function for the WP native test bootstrap in the typical location used by the WP-CLIscaffoldinstall-wp-tests.shscript.This means that if the
install-wp-tests.shscript is used without adjustments, the path to the WP native test bootstrap should be findable by WP Test Utils without needing to set theWP_TESTS_DIRconstant.Fixes #12
@swissspidy @GaryJones Would be great if either of you had a chance to look this over/test it!