Try gutenberg more menu plugin filter#9066
Closed
igorschoester wants to merge 2 commits intotrunkfrom
Closed
Conversation
afercia
reviewed
Feb 28, 2018
| <IconButton | ||
| className="components-menu-items__button components-menu-items__button components-icon-button components-menu-item-plugins__button has-icon" | ||
| icon={ | ||
| <div className="components-menu-item-plugins__icon-container" > |
Contributor
There was a problem hiding this comment.
Please consider this is not valid HTML. Buttons can't contain div elements. Maybe consider to add a className to the icon and style that instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This branch shows how the more menu API from WordPress/gutenberg#5161 can be used.