Enforce post objects to WP_Post in class WPSEO_Post_Type_Sitemap_Provider#16313
Merged
Enforce post objects to WP_Post in class WPSEO_Post_Type_Sitemap_Provider#16313
Conversation
7 tasks
Contributor
|
CR: 👍 |
Member
Contributor
Author
|
The class WP_Post contains some default properties ( eg. Also, we should keep post_author because someone can check it via the filter wpseo_sitemap_entry (3rd argument ). |
Contributor
|
I'm of a mind to rebuild XML sitemaps on top of indexables anyway, so this fixes the bug, which is fine. Merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Documentation
Quality assurance
Fixes #16308