Skip to content

GH Actions: set error reporting to E_ALL#44

Merged
jrfnl merged 1 commit into
developfrom
feature/ghactions-turn-on-error-reporting
Jun 22, 2021
Merged

GH Actions: set error reporting to E_ALL#44
jrfnl merged 1 commit into
developfrom
feature/ghactions-turn-on-error-reporting

Conversation

@jrfnl

@jrfnl jrfnl commented Jun 22, 2021

Copy link
Copy Markdown
Collaborator

Turns out the default setting for error_reporting used by the SetupPHP action is error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT and display_errors is set to Off.

For the purposes of CI, I'd recommend running with E_ALL and display_errors=On to ensure all PHP notices are shown.

Turns out the default setting for `error_reporting` used by the SetupPHP action is `error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT` and `display_errors` is set to `Off`.

For the purposes of CI, I'd recommend running with `E_ALL` and `display_errors=On` to ensure **all** PHP notices are shown.
@jrfnl jrfnl added this to the 1.x Next Release milestone Jun 22, 2021
@jrfnl jrfnl merged commit 1b89291 into develop Jun 22, 2021
@jrfnl jrfnl deleted the feature/ghactions-turn-on-error-reporting branch June 22, 2021 01:56
@jrfnl jrfnl removed the yoastcs/qa label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant