Skip to content

Allow for using the polyfills on PHP 5.4#19

Merged
jrfnl merged 1 commit into
developfrom
JRF/support-php-5.4
Jun 5, 2021
Merged

Allow for using the polyfills on PHP 5.4#19
jrfnl merged 1 commit into
developfrom
JRF/support-php-5.4

Conversation

@jrfnl

@jrfnl jrfnl commented Jun 5, 2021

Copy link
Copy Markdown
Collaborator

There was only one PHP 5.5 specific syntax being used in this library - ::class -.
This was the only blocker for allowing tests using the polyfills to run on PHP 5.4.

This blocker has now been removed, making the polyfills available on PHP 5.4 in combination with PHPUnit 4.8.x as well.

Note: there are 11 tests being marked as "risky" on PHP 5.4. This is the same on PHP 5.5 and is unrelated to this library, but to do with an underlying issue in the older PHPUnit versions themselves.
I do not consider this a blocker as the tests *will run and do pass.

Details of the tests marked as risky (fold out for details) 
1) Yoast\PHPUnitPolyfills\Tests\Polyfills\ExpectExceptionTest::testExpectExceptionCodeException
Test code or tested code did not (only) close its own output buffers

2) Yoast\PHPUnitPolyfills\Tests\Polyfills\ExpectExceptionTest::testExpectExceptionMessageException
Test code or tested code did not (only) close its own output buffers

3) Yoast\PHPUnitPolyfills\Tests\Polyfills\ExpectExceptionTest::testExpectExceptionMessageAndCodeFailOnCode
Test code or tested code did not (only) close its own output buffers

4) Yoast\PHPUnitPolyfills\Tests\Polyfills\ExpectExceptionTest::testExpectExceptionMessageAndCodeFailOnMsg
Test code or tested code did not (only) close its own output buffers

5) Yoast\PHPUnitPolyfills\Tests\Polyfills\ExpectExceptionTest::testExpectExceptionMessageRegExpAndCodeFailOnCode
Test code or tested code did not (only) close its own output buffers

6) Yoast\PHPUnitPolyfills\Tests\Polyfills\ExpectExceptionTest::testExpectExceptionMessageRegExpAndCodeFailOnMsg
Test code or tested code did not (only) close its own output buffers

7) Yoast\PHPUnitPolyfills\Tests\TestListeners\TestListenerTest::testError
Test code or tested code did not (only) close its own output buffers

8) Yoast\PHPUnitPolyfills\Tests\TestListeners\TestListenerTest::testFailure
Test code or tested code did not (only) close its own output buffers

9) Yoast\PHPUnitPolyfills\Tests\TestListeners\TestListenerTest::testIncomplete
Test code or tested code did not (only) close its own output buffers

10) Yoast\PHPUnitPolyfills\Tests\TestListeners\TestListenerTest::testSkipped
Test code or tested code did not (only) close its own output buffers

11) Yoast\PHPUnitPolyfills\Tests\TestListeners\TestListenerTest::testStartStop
Test code or tested code did not (only) close its own output buffers

@jrfnl
Allow for using the polyfills on PHP 5.4
3ba9692 
There was only one PHP 5.5 specific syntax being used in this library - `::class` -.
This was the only blocker for allowing tests using the polyfills to run on PHP 5.4.

This blocker has now been removed, making the polyfills available on PHP 5.4 in combination with PHPUnit 4.8.x as well.
@jrfnl jrfnl added this to the 0.x Next Release milestone Jun 5, 2021
@jrfnl jrfnl merged commit 559859e into develop Jun 5, 2021
@jrfnl jrfnl deleted the JRF/support-php-5.4 branch June 5, 2021 16:22
@jrfnl jrfnl removed the yoastcs/qa label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Type: enhancement

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

1 participant

@jrfnl