fix(lxc): remove protobufs from sparse cone (git submodule, not a directory)#3793
Merged
Merged
Conversation
protobufs is a git submodule (gitlink), not a regular directory. Cone-mode sparse-checkout rejects gitlink paths — this is why --skip-checks was added to the sparse-checkout set command. The submodule is populated by git submodule update --init --recursive in Step 6 of build-lxc-template.sh, independently of the cone list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protobufswas added back tolxc/sparse-cone.txtin #3768 but it shouldnot be listed there. It is a git submodule (gitlink), not a regular directory —
cone-mode sparse-checkout rejects gitlink paths, which is why
--skip-checkswas added to the
sparse-checkout setcommand inbuild-lxc-template.sh.The submodule is populated by
git submodule update --init --recursiveinStep 6 of the build script, independently of the cone list. Listing it here
is redundant and potentially confusing.
Added a note in the MAINTENANCE section so this isn't accidentally re-added.
Changes
lxc/sparse-cone.txt— removeprotobufs, add maintenance note explaining whyIssues Resolved
Follow-up to #3768.
Testing
No rebuild needed — this is a documentation/config correction only. The build
script's
--skip-checksflag already handles this gracefully; removingprotobufsfrom the cone list simply eliminates the redundant entry.