Claude finished @Yeraze's task —— View job

PR Review: feat(meshcore): compact {ROUTE} auto-ack variable (#3776)

• Read changed files
• Review code quality and best practices
• Check test coverage
• Assess security and performance
• Post final review

Summary

This is a clean, well-scoped change. The core modification (dropping spaces around → in the route join) is minimal and correct, and the test suite is thorough for what it covers.

Code Quality

meshcoreManager.ts (lines 5212–5223)

The implementation is clean. The updated comment accurately documents the rationale and references the issue number, which is good practice.

One minor observation: the hardcoded version string on line 5241 (replace(/\{VERSION\}/g, '4.8.0')) is unrelated to this PR, but it's a pre-existing issue worth flagging — it'll silently serve stale version info as the codebase advances. Not a blocker, but worth a follow-up.

Test Coverage

meshcoreManager.autoAckRoute.test.ts

The test file is well-structured and covers the key cases:

• ✅ Multi-hop route with bare arrow (guards against regression to →)
• ✅ Trimming and filtering of malformed/empty tokens
• ✅ Single-hop (no arrow rendered)
• ✅ direct fallback (0 hops, no route)
• ✅ — fallback (unknown route + unknown hops)

One gap worth noting: There is no test for the case where route is a non-null but effectively empty string after filtering (e.g., route = "," or route = " , " with hops !== 0). The current code:

if (route && route.length > 0) {
  routeStr = route
    .split(',')
    .map(h => h.trim())
    .filter(Boolean)
    .join('→');

If route = "," and hops = 2, the filter(Boolean) drops all tokens, resulting in routeStr = "" (empty string). The fallback branches are skipped since route was truthy. This means {ROUTE} would expand to an empty string rather than —. This is a pre-existing edge case, but the new test file is a good place to cover it if you want to harden this path.

Security & Performance

No concerns. This is a display/formatting change with no I/O, no user-facing attack surface beyond a 2-byte airtime savings, and no performance implications.

Overall

Approved direction — the change is correct, minimal, and well-tested for the happy path and the main edge cases. The empty-token-after-filter edge case is worth a follow-up test but is not a blocker for this PR.