docs: restore Duplicate Encryption Keys page to the public site#3534
Conversation
The 'Duplicate Encryption Keys' page is a user-directed security warning
('If you were sent here, it's because your Node is vulnerable...') that
affected users reach via a public short link
(https://bit.ly/4okVACV → https://meshmonitor.org/security-duplicate-keys).
PR #3138 moved it into docs/internal/dev-notes/, which is srcExclude'd
('**/internal/**') from the VitePress build — so the public URL started
returning 404 and the short link became a dead end.
Move it back to docs/security-duplicate-keys.md (restoring the exact
/security-duplicate-keys URL the short link targets) and add a sidebar entry
under Administration & Security for discoverability. Verified: docs build
succeeds and emits dist/security-duplicate-keys.html.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Claude finished @Yeraze's task —— View job PR Review: docs: restore Duplicate Encryption Keys page to the public site
SummaryThis is a clean, minimal, and correct fix. The PR does exactly what it needs to — no more, no less. Changes Reviewed
{ text: 'Duplicate Encryption Keys', link: '/security-duplicate-keys' },Correctly placed under Administration & Security in the
Verdict: LGTM ✅
One minor note: the page footer still says |
Same fix as the Duplicate Keys page for its sibling user-directed warning: move docs/internal/dev-notes/security-low-entropy-keys.md back to docs/security-low-entropy-keys.md so /security-low-entropy-keys is published again, and add a sidebar entry under Administration & Security. Also repoint automation.md's two 'Duplicate Encryption Keys' links from the now-moved internal GitHub-blob path to the site-relative /security-duplicate-keys (those would otherwise 404 after the move). The low-entropy page's relative link to ./security-duplicate-keys.md resolves correctly now that both pages live at the docs root. Verified: docs build succeeds with no dead links; both pages emit HTML. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Claude finished @Yeraze's task —— View job PR Review: docs: restore Duplicate Encryption Keys page to the public site
SummaryClean, correct fix. The PR does exactly what it needs to with no unintended side effects. Changes Reviewed
{ text: 'Duplicate Encryption Keys', link: '/security-duplicate-keys' },
{ text: 'Low-Entropy Encryption Keys', link: '/security-low-entropy-keys' },Both link paths correctly match their respective file locations (
- [Duplicate Encryption Keys](https://github.com/Yeraze/meshmonitor/blob/main/docs/internal/dev-notes/security-duplicate-keys.md)
+ [Duplicate Encryption Keys](/security-duplicate-keys)This is exactly right — the old links pointed at the raw GitHub file viewer (would show markdown source, not rendered docs), and now they point to the live docs site. Verdict: LGTM ✅
One pre-existing note out of scope for this PR: |
Problem
https://meshmonitor.org/security-duplicate-keysreturns 404. That URL is the target of a public short link (https://bit.ly/4okVACV→ 301 →/security-duplicate-keys) that affected users are directed to — the page itself opens with "If you were sent here, it's because your Node is vulnerable to security issues."Cause
PR #3138 (docs reorg) moved
docs/security-duplicate-keys.md→docs/internal/dev-notes/security-duplicate-keys.md. The VitePress configsrcExcludes**/internal/**, so the page stopped being published and the public URL — and thus the short link — became a dead end.Fix
docs/security-duplicate-keys.md, restoring the exact/security-duplicate-keysURL the short link targets.Verified
npm run docs:buildsucceeds (no dead-link failures) and emitsdist/security-duplicate-keys.html(title Duplicate Encryption Keys).docs/internal/..mdlinks, so the move introduces no broken links.Once this deploys,
https://meshmonitor.org/security-duplicate-keys(and the bit.ly) resolve again.🤖 Generated with Claude Code