Skip to content

Visual novel example#6

Merged
desplesda merged 8 commits intodevelopfrom
feature/visual-novel-example
Jun 18, 2020
Merged

Visual novel example#6
desplesda merged 8 commits intodevelopfrom
feature/visual-novel-example

Conversation

@desplesda
Copy link
Member

This is a continuation of the work started in YarnSpinnerTool/YarnSpinner#213.

yangrobertw and others added 4 commits June 5, 2020 16:26
…DialogueUI.cs to inherit from DialogueUI.cs and updated it to use more Yarn Spinner v1.0+ conventions (e.g. event-based text update)... still need to do some clean-up, but it's mostly working
…d VNDialogueUI to modify a temporary copy of the string table instead of overwriting the permanent string table; tightened up the example VNExampleDialogue.yarn; added documentation in VisualNovel_Readme.md
…extracted from the VN example, connects to VNManager via UnityEvents
@radiatoryang
Copy link
Contributor

Thanks for moving this over! There's two options to proceed:

  • merge this in for a possible v1.3 release? I also have a messaging app style ChatExample and a dynamically positioned speech bubble BubbleExample ready to go, that I would submit in separate PRs
  • wait until v2.0... at that point, DialogueUISplit.cs won't be necessary and this example will just be about showing extensive use of Yarn Commands

Let me know what would make the most sense.

@desplesda
Copy link
Member Author

I'd like to update the code in this to the new dialogue view architecture that's now in develop, and release it as part of 2.0.

@desplesda desplesda merged commit 7eb34ad into develop Jun 18, 2020
@desplesda desplesda deleted the feature/visual-novel-example branch June 18, 2020 01:29
@desplesda
Copy link
Member Author

I've merged this into develop, which involved updating the UI components to use the dialogue views that are now in develop. This involved removing DialogueUISplit, and creating a new class DialogueCharacterNameView that handles the name view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants