Improve/non native/2.2.8 prs integration#812
Merged
severianremi merged 12 commits intodevelop-non-nativefrom Jan 27, 2022
Merged
Improve/non native/2.2.8 prs integration#812severianremi merged 12 commits intodevelop-non-nativefrom
severianremi merged 12 commits intodevelop-non-nativefrom
Conversation
Signed-off-by: dmorozov <dmytro.morozov@yalantis.net>
- change fallback for EXTRA_ASPECT_RATIO_X and EXTRA_ASPECT_RATIO_Y to "-1" as "0" has special meaning - fix usage of useSourceImageAspectRatio (now properly hides mWrapperStateAspectRatio) - fix setTargetAspectRatio at processOptions due to Float.NaN (allows custom aspect ratio definitions with default ratio set to x=CropImageView.DEFAULT_ASPECT_RATIO and y=CropImageView.DEFAULT_ASPECT_RATIO) - fix sanity check at setAspectRatioOptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this PR as an integrational part of 2.2.8 release. Once PR is accepted we will start testing on the develop-non-native branch. Once tested these changes will be released to master-non-native as 2.2.8 version.