fix: address review feedback on PR #89#93
Merged
Conversation
- vault_path.go: return absolute path names directly without reading obsidian.json, handling the common case of storing full paths as the default vault - set_default.go: path resolution after setting the vault name is now best-effort; use fmt.Fprintln(os.Stderr) instead of log.Printf for consistency with surrounding fmt.Println calls - vault_path_test.go: use t.Cleanup for mock restore so it runs even if t.Fatal fires; fix WSL C: drive test to use "Obsidian Vault" as vault name matching the path suffix, per reviewer suggestion
Owner
|
Thank you for the new PR, I will take a look as soon as I can! |
Contributor
Author
|
Btw I wrote a skill that uses your CLI: https://clawhub.ai/TriplEight/obsidian-linux |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #89
Addresses the review comments from #89:
vault_path.go: return absolute path names directly without readingobsidian.json, handling the common case of storing full paths as the default vaultset_default.go: path resolution after setting the vault name is best-effort; usefmt.Fprintln(os.Stderr, ...)instead oflog.Printffor consistency with surroundingfmt.Printlncallsvault_path_test.go: uset.Cleanupfor mock restore so it runs even ift.Fatalfires inside the mock; fix WSL C: drive test to use"Obsidian Vault"as the vault name matching the path suffixChecklist: