add section flag to open command#74
Merged
Merged
Conversation
- Introduced `--section` flag to allow opening notes at specific headings. - Updated `OpenParams` struct to include `Section`. - Modified `OpenNote` function to handle section parameter. - Enhanced tests to verify functionality with sections.
Contributor
Author
|
got reference from this discussion https://forum.obsidian.md/t/url-scheme-direct-navigation-to-heading/5907/25 
Opened here like this 
|
There was a problem hiding this comment.
Pull request overview
This PR adds section navigation support to the open command, allowing users to jump directly to specific headings in long Obsidian notes.
Changes:
- Added
--sectionflag to theopencommand for direct heading navigation - Updated
OpenParamsstruct andOpenNotefunction to support section parameter - Enhanced test coverage with section-specific test cases
- Updated README with usage examples for the new flag
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/actions/open.go | Added Section field to OpenParams and logic to append section to file parameter when specified |
| pkg/actions/open_test.go | Added test assertions for section parameter handling and new test case for section navigation |
| mocks/uri.go | Enhanced MockUriManager to track LastBase and LastParams for better test assertions |
| cmd/open.go | Added sectionName variable and --section flag to the open command CLI |
| README.md | Added documentation and usage examples for the new --section flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I think review is done… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
open --sectionheading navigationDescription
--sectionflag to open notes at a specific heading.OpenParamsto includeSection.OpenNoteto append#<heading>to the file parameter.open --sectionusage.Motivation and Context
Issue #71 requests direct section navigation when opening long notes. This change allows users to jump to an exact heading using Obsidian’s URI behavior, while keeping default
openbehavior unchanged.Checklist: