Conversation
Might have prevented YOURLS/YOURLS#3337
Deploying with
|
| Latest commit: |
44ba207
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://15f0b1b2.yourls-docs.pages.dev |
ozh
left a comment
There was a problem hiding this comment.
This is a very default extension and so far there has been only one issue about this. There are a lot of default extensions that YOURLS needs (hash, PDO, json...) and that would be maybe overkill to list them all (and maybe letting noob users think YOURLS requires an awful lot of custom stuff). Thoughts?
|
Maybe this exact page/bullet-point is the wrong place for such a list, but I'd say that the required extensions should be listed somewhere in the documentation for reference. |
|
Nothing against it, but I don't know how to generate a list of needed default extensions ... |
|
I took a quick trip to google and found that Composer might be able to do it ( Maybe this is a half-baked Composer feature? The result didn't change after As an alternative I tried out https://github.com/RogerGee/php-ext-depends, with a better (but still seemingly incomplete) result: Still, this should be most of what's required. Amendments can be made if users find something that isn't listed causes an error when missing. (Also I just noticed that my branch name is wrong. How did I get an |
|
This list isn't accurate either. For instance, I would suggest we
Emphasis on "for 99.9% of folks we just need standard stuff" |
|
Regarding the specific case of mysqlnd, I think it's de facto covered by the "ext-pdo": "*", we already have |
|
Ah well, the readme for php-ext-depends specifically says that it doesn't try to determine if use of an extension function is in an optional code path. I went through the previous list real quick and annotated things as best I could:
If my conclusions are reasonable, I'd happily take a stab at updating composer.json with this info. Later I can change this docs PR to point to said updated file for more details. |
|
👍 |
|
👍 for this complete list! |
|
Updated this to how it might look when pointing to |
|
And there we go: YOURLS/YOURLS#3339 |
Might have prevented YOURLS/YOURLS#3337