Conversation
dgw
reviewed
Dec 17, 2025
Member
dgw
left a comment
There was a problem hiding this comment.
I have a small nitpick, but also a fundamental question: Why not simply reject invalid JSONP callbacks with an error?
As I understand JSONP, whether YOURLS explicitly returns an error response or silently modifies the callback name, the calling script won't do what's expected. Might as well make the reason obvious, IMO.
Member
Author
Absolutely. Will change this 👍 |
Remove formatting caused by cat stepping on keyboard Co-authored-by: dgw <dgw@technobabbl.es>
Return explicit error message and HTTP status code if invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.