Skip to content

Defer loading textdomain after plugins#3679

Merged
LeoColomb merged 1 commit intomasterfrom
defer_mo
Jul 29, 2025
Merged

Defer loading textdomain after plugins#3679
LeoColomb merged 1 commit intomasterfrom
defer_mo

Conversation

@ozh
Copy link
Copy Markdown
Member

@ozh ozh commented Dec 3, 2023

Currently the main textdomain is enforced before plugins load. This prevents user plugins from altering the global setting YOURLS_LANG as defined in the DB.

I think there would be no unwanted side effect if we loaded the language after plugins ?

@8MiYile
Copy link
Copy Markdown

8MiYile commented Dec 3, 2023

This kind of thing is mainly to see that the website administrator has not installed the language plug-in, if there is a language plug-in, because the plug-in is manually installed

@8MiYile
Copy link
Copy Markdown

8MiYile commented Jun 23, 2025

okay it's working
so how time todo merge

@ozh
Copy link
Copy Markdown
Member Author

ozh commented Jul 29, 2025

Old stuff but LGTM, thoughts @YOURLS/core ?

@LeoColomb LeoColomb enabled auto-merge (rebase) July 29, 2025 12:50
@LeoColomb LeoColomb merged commit dbc5451 into master Jul 29, 2025
10 checks passed
@LeoColomb LeoColomb deleted the defer_mo branch July 29, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants