Well at least now it's consistent ....

30 000 tests on my dev box, cannot reproduce. FML.

So, still haven't found the specific issue with these two tests. I've improved things here and there in the process of searching I think, so in the end if we drop this PR make sure we still cherry pick useful commits.

So. I'm out of ideas. Still no clue why this happens sometimes, and not being able to reproduce on my machine despite the thousands of tests doesn't help.

I think I'm just going to remove these tests and live with it :-)

More random inconsistency with phpunit --repeat : sometimes I have a failure on \tests\tests\utilities\get_request.php:111

GetRequest_Tests::test_get_request with data set #32 ('MiXeD', 'http://SHO.rt/', '/MiXeD')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'MiXeD'
+'mixed'

Yet this test is absolutely DB or option or whatever independent. Djeezus.

Meeeeh. I think I've found.

What a suspens! What was the cause?

@LeoColomb testing the next shorturl id was failing when the previously loaded plugin was "random-shorturl". Captain Obvious to the rescue. The whole "let's load a real plugin to test the plugin API" was so dumb it's appalling in retrospective :)

Nice one! 🎉 👍