-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Code of Conduct
- I agree to follow this project's Code of Conduct.
Submission validity
- This is not a personal support request, that should be posted on discussions community.
- I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.
Self troubleshooting
- I've read the documentation and made sure to follow it.
- I've read the troubleshooting first steps and frequent issues guides.
Version
1.9.1
Description
When editing not the first url in list (e.g. second) and saving it, the changed entry will be placed on top of the list.
When refreshing the page it shows that it is saved correctly.
Javascript bug when saving.
Expectation
When saved the correct line is being updated.
Reproduction steps
- Go to Admin
- Have at least two entries
- Edit second entry inline and hit save
- Will be placed in the first line
Context
Investigation:
- yourls_table_edit_row is handling the keyword only
- it calls yourls_unique_element_id without any id parameter thus always returning the id for the first row
- html of the ajax request for getting edit html will always returning the edit row with the first result
Suggested solution:
- call yourls_table_edit_row with optional parameter (id / row id)
- in yourls_table_edit_row call yourls_unique_element_id with parameter
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working