Conversation
Signed-off-by: Xuanwo <github@xuanwo.io>
tisonkun
reviewed
Feb 13, 2025
Comment on lines
+23
to
26
| default = ["std-blocking-sleep", "tokio-sleep", "gloo-timers-sleep"] | ||
| std-blocking-sleep = [] | ||
| gloo-timers-sleep = ["dep:gloo-timers", "gloo-timers?/futures"] | ||
| tokio-sleep = ["dep:tokio", "tokio?/time"] |
There was a problem hiding this comment.
I may prefer default to none and only opt-in features when necessary.
For example, most users of tokio-sleep don't need gloo-timers-sleep. Although, currently we can use "default-feature = false".
Owner
Author
There was a problem hiding this comment.
The motivation for this change is to ensure that backon's old users can continue working smoothly after upgrading to v1.0. We can revisit this while preparing for v2.0. However, since this change can break users silently, it might be best to leave it as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.