Skip to content

docs: Add sleep in README#131

Merged
Xuanwo merged 1 commit intomainfrom
polish-readme
Aug 29, 2024
Merged

docs: Add sleep in README#131
Xuanwo merged 1 commit intomainfrom
polish-readme

Conversation

@Xuanwo
Copy link
Copy Markdown
Owner

@Xuanwo Xuanwo commented Aug 29, 2024

No description provided.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 64fdcfd into main Aug 29, 2024
@Xuanwo Xuanwo deleted the polish-readme branch August 29, 2024 16:11
// Retry with exponential backoff
.retry(ExponentialBuilder::default())
// Sleep implementation, required if no feature has been enabled
.sleep(tokio::time::sleep)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this to the blocking retry example as well? i.e., something like:

.sleep(std::thread::sleep)

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me add it:)

Xuanwo pushed a commit that referenced this pull request Sep 4, 2024
### What does this PR do

Based on the
[discussion](#131 (comment)),
mention `sleep()` in the blocking retry examples.

Added to examples in both `README.md` and `lib.rs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants