Fix: Add hover window color scheme support #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add HOVER_BACKGROUND, HOVER_TEXT_NORMAL, and HOVER_TEXT_HIGHLIGHTED color scheme entries to ensure LSP hover windows use proper theming consistent with other editor UI elements like completion and diagnostic tooltips.
Change BaseLspConnector to use getOrCreateEditor() instead of createEditor() to avoid creating duplicate editor instances for the same file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for hover window color scheme customization in the LSP editor.
Bug Fixes
Note
Need merge upstream updates from sora-editor (Rosemoe/sora-editor#733) in soraX submodule, which includes bug fixes for lsp.