-
-
Notifications
You must be signed in to change notification settings - Fork 92
feat(main): implement proper command palette #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(main): implement proper command palette #902
Conversation
You are right, Acode has implementation similar to this |
6d37736 to
f5571b5
Compare
|
I was waiting for this feature for a long time |
|
@RohitKushvaha01 Do you have any idea how to fix the keyboard flickering? Steps to reproduce the issue
|
This happens because Editor is a AndroidView and the InputFeild in command palatte is a composable, to fix this you have to use EditText view using AndroidView in place of inputfield |
Then I have no Material Design input, I'll just leave it as is, it's not that big of a problem. |
…o feat/better-command-palette
|
@RohitKushvaha01 |
This PR improves the command palette in Xed-Editor.
It is intended to close #891 and #661 in the future.
Features
I also made two small LSP corrections here, one for the theming and one for a language inconsistency.
Missing features
KEYBINDS.mdTodos for another PR
Screenshots
Note
@RohitKushvaha01
The current problem, however, and also the reason why this is only a draft, is that I don't know where to store the commands. We need a universal solution, as there is currently duplicate code, as the commands are registered in
CommandProvider.ktand, for example,EditorActions.kt.I would suggest simply storing all actions in the
CommandProviderand accessing them from theEditorActions.