Skip to content

refactor(main): refactor names from Karbon to Xed #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RohitKushvaha01 merged 2 commits into from
Oct 24, 2025
Merged

refactor(main): refactor names from Karbon to Xed #899

RohitKushvaha01 merged 2 commits into from
Oct 24, 2025

Conversation

@KonerDev
Copy link
Member

@KonerDev KonerDev commented Oct 24, 2025

Changes

  • Remove unused imports
  • Migrate names like KarbonTheme to XedTheme
  • Ensure name consistency in SettingsRoutes.kt

github-actions[bot]

This comment was marked as spam.

Sign in to view

RohitKushvaha01
RohitKushvaha01 requested changes Oct 24, 2025
View reviewed changes
@Xed-Editor Xed-Editor deleted a comment from github-actions bot Oct 24, 2025
@github-actions
Copy link

github-actions bot commented Oct 24, 2025 •
edited
Loading

PR Summary

This PR performs a comprehensive refactoring, migrating all instances of Karbon to Xed and KarbonEditor to Editor across the codebase. This includes renaming the KarbonEditor.kt file to Editor.kt, updating class names, theme references (e.g., KarbonTheme to XedTheme), and associated imports. Additionally, several unused imports were removed, and settings route names were standardized for improved consistency.

Changes

File Summary
core/main/src/main/java/com/rk/App.kt Refactored KarbonEditor to Editor in imports and usage, and removed several unused imports like android.system.Os and java.nio.file.Files.
core/main/src/main/java/com/rk/crashhandler/CrashActivity.kt Migrated KarbonEditor to Editor and KarbonTheme to XedTheme in imports and usage, ensuring consistent naming within the crash activity.
core/main/src/main/java/com/rk/libcommons/LoadingPopup.kt Updated the theme reference from KarbonTheme to XedTheme within the LoadingPopup component for UI consistency.
core/main/src/main/java/com/rk/libcommons/Utils.kt Renamed the theme reference from KarbonTheme to XedTheme within the composeDialog function to align with the new naming convention.
core/main/src/main/java/com/rk/libcommons/editor/BaseLspConnector.kt Refactored all references to KarbonEditor to Editor within the BaseLspConnector class, including imports, parameter types, and property assignments.
core/main/src/main/java/com/rk/libcommons/editor/Editor.kt Renamed the file from KarbonEditor.kt to Editor.kt and updated the class definition from class KarbonEditor to class Editor.
core/main/src/main/java/com/rk/runner/runners/web/WebActivity.kt Removed an unused import for ArrowBack icon and updated the theme reference from KarbonTheme to XedTheme in the WebActivity.
core/main/src/main/java/com/rk/runner/runners/web/markdown/MDViewer.kt Removed several unused imports related to error dialogs and resources, and updated the theme reference from KarbonTheme to XedTheme in the markdown viewer.
core/main/src/main/java/com/rk/tabs/EditorTab.kt Refactored all instances of KarbonEditor to Editor within the EditorTab component, affecting state, type checks, and editor instantiation.
core/main/src/main/java/com/rk/xededitor/ui/activities/main/MainActivity.kt Performed extensive cleanup by removing numerous unused imports and updated the theme reference from KarbonTheme to XedTheme in the MainActivity.
core/main/src/main/java/com/rk/xededitor/ui/activities/settings/SettingsActivity.kt Updated the theme reference from KarbonTheme to XedTheme within the SettingsActivity for consistent UI theming.
core/main/src/main/java/com/rk/xededitor/ui/activities/settings/SettingsRoutes.kt Standardized several settings route names by converting them to snake_case (e.g., editorFontScreen to editor_font_screen) and renamed the karbon route to about.
core/main/src/main/java/com/rk/xededitor/ui/activities/terminal/Terminal.kt Removed unused imports related to file paths and dialogs, and updated the theme reference from KarbonTheme to XedTheme in the Terminal activity.
core/main/src/main/java/com/rk/xededitor/ui/theme/Theme.kt Renamed the primary theme composable function from KarbonTheme to XedTheme to align with the new branding.

autogenerated by presubmit.ai

github-actions[bot]
github-actions bot reviewed Oct 24, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

Review Summary

Commits Considered (2)
  • de20de2: fix(main): rename XedEditor class to Editor for clarity
  • a4d9b9f: refactor(main): refactor names from Karbon to Xed
Files Processed (14)
  • core/main/src/main/java/com/rk/App.kt (3 hunks)
  • core/main/src/main/java/com/rk/crashhandler/CrashActivity.kt (3 hunks)
  • core/main/src/main/java/com/rk/libcommons/LoadingPopup.kt (2 hunks)
  • core/main/src/main/java/com/rk/libcommons/Utils.kt (2 hunks)
  • core/main/src/main/java/com/rk/libcommons/editor/BaseLspConnector.kt (4 hunks)
  • core/main/src/main/java/com/rk/libcommons/editor/Editor.kt (from core/main/src/main/java/com/rk/libcommons/editor/KarbonEditor.kt) (1 hunk)
  • core/main/src/main/java/com/rk/runner/runners/web/WebActivity.kt (2 hunks)
  • core/main/src/main/java/com/rk/runner/runners/web/markdown/MDViewer.kt (2 hunks)
  • core/main/src/main/java/com/rk/tabs/EditorTab.kt (6 hunks)
  • core/main/src/main/java/com/rk/xededitor/ui/activities/main/MainActivity.kt (3 hunks)
  • core/main/src/main/java/com/rk/xededitor/ui/activities/settings/SettingsActivity.kt (2 hunks)
  • core/main/src/main/java/com/rk/xededitor/ui/activities/settings/SettingsRoutes.kt (1 hunk)
  • core/main/src/main/java/com/rk/xededitor/ui/activities/terminal/Terminal.kt (2 hunks)
  • core/main/src/main/java/com/rk/xededitor/ui/theme/Theme.kt (1 hunk)
Actionable Comments (0)
Skipped Comments (0)

@RohitKushvaha01 RohitKushvaha01 merged commit 49db5fa into Xed-Editor:main Oct 24, 2025
1 check passed
@KonerDev KonerDev deleted the refactor/karbon-to-xed branch November 1, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@RohitKushvaha01 RohitKushvaha01 RohitKushvaha01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KonerDev @RohitKushvaha01