Skip to content

fix(main): reuse the same LspProject #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RohitKushvaha01 merged 2 commits into from
Oct 19, 2025
Merged

fix(main): reuse the same LspProject #886

RohitKushvaha01 merged 2 commits into from
Oct 19, 2025

Conversation

@KonerDev
Copy link
Member

@KonerDev KonerDev commented Oct 19, 2025

Changes

  • Reuse the same LspProject and CustomLanguageServerDefinitions if the parent path is the same or the definition has already been created
  • Refactor close project dialog to always use CloseConfirmationDialog
  • Use appropriate name (instead of 0, use Storage)

@github-actions
Copy link

github-actions bot commented Oct 19, 2025 •
edited
Loading

PR Summary

This PR enhances LSP project management by introducing caching for LspProject instances and CustomLanguageServerDefinitions, ensuring that the same project and server definitions are reused when the parent path or definition already exists. Additionally, it refactors the project closing dialogs across the application to consistently use a shared CloseConfirmationDialog component, improving UI consistency and using more appropriate naming conventions like getAppropriateName() for projects.

Changes

File Summary
core/main/src/main/java/com/rk/compose/filetree/Drawer.kt Refactored the project closing mechanism within the DrawerContent composable. The local state closeProjectDialog was simplified to a boolean, and the custom AlertDialog was replaced with a reusable CloseConfirmationDialog component, improving consistency and using a more appropriate project name.
core/main/src/main/java/com/rk/libcommons/editor/BaseLspConnector.kt Implemented caching for LspProject and CustomLanguageServerDefinition instances. The connect method now reuses existing LspProject objects based on the project path and CustomLanguageServerDefinition objects based on both project path and file extension, preventing redundant object creation.
core/main/src/main/java/com/rk/xededitor/ui/components/FileActionDialog.kt Updated the FileActionDialog to use the getAppropriateName() extension function when displaying the project name in the CloseConfirmationDialog. The CloseConfirmationDialog composable was also refactored to accept projectName instead of fileName for clarity and consistency.

autogenerated by presubmit.ai

github-actions[bot]
github-actions bot reviewed Oct 19, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

Review Summary

Commits Considered (2)
  • 70208f6: fix(main): refactor and use proper name
  • d7a3657: fix(main): reuse the same LspProject
Files Processed (3)
  • core/main/src/main/java/com/rk/compose/filetree/Drawer.kt (4 hunks)
  • core/main/src/main/java/com/rk/libcommons/editor/BaseLspConnector.kt (3 hunks)
  • core/main/src/main/java/com/rk/xededitor/ui/components/FileActionDialog.kt (5 hunks)
Actionable Comments (0)
Skipped Comments (1)
  • core/main/src/main/java/com/rk/compose/filetree/Drawer.kt [309-309]

    possible bug: "Potential NullPointerException with currentProject"

@RohitKushvaha01 RohitKushvaha01 merged commit 6ff72b3 into Xed-Editor:main Oct 19, 2025
@KonerDev KonerDev deleted the fix/projects branch October 19, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KonerDev @RohitKushvaha01