Skip to content

chore(resources): refactor resource names and change OLED desc #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RohitKushvaha01 merged 1 commit into from
Oct 17, 2025
Merged

chore(resources): refactor resource names and change OLED desc #883

RohitKushvaha01 merged 1 commit into from
Oct 17, 2025

Conversation

@KonerDev
Copy link
Member

@KonerDev KonerDev commented Oct 17, 2025

This PR consists of the most important changes proposed in #860.

Changes

  • Change OLED theme description
  • Change undescriptive resource names (e.g. ww to word_wrap)
  • Remove duplicate strings
  • Remove a few unused translations

@github-actions
Copy link

github-actions bot commented Oct 17, 2025 •
edited
Loading

PR Summary

Refactored various string resource names for improved clarity and consistency, replacing abbreviations like ww with word_wrap and rr with restart_required. The description for the OLED theme setting was also updated to be more informative. Additionally, several unused and duplicate string resources were removed across all language localization files, contributing to a cleaner and more maintainable codebase.

Changes

File Summary
core/main/src/main/java/com/rk/xededitor/ui/screens/settings/editor/SettingsEditorScreen.kt Updated string resource references in the SettingsEditorScreen to use the new, more descriptive names. This included changes for word wrap, TXT file word wrap, restart required messages, and validation error messages, enhancing readability and consistency.
core/main/src/main/res/menu/menu_main.xml Updated the toggle_word_wrap menu item's title to reference the newly named string resource toggle_word_wrap, improving consistency with the refactored resource names.
core/resources/src/main/res/values-ar/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-arq/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait, improving resource clarity and consistency.
core/resources/src/main/res/values-bn-rIN/strings.xml Refactored string resource names, replacing abbreviations like ww with word_wrap and ww_wait with word_wrap_wait. Removed duplicate string rr, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-bn/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait, improving resource clarity and consistency.
core/resources/src/main/res/values-cs/strings.xml Refactored string resource names, replacing abbreviations like ww with word_wrap and invalid_v with value_invalid. Removed duplicate string rr and unused strings like file_exist_not and preview_err, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-de/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_type, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-es/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused string file_exist_not, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-fa/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait, improving resource clarity and consistency.
core/resources/src/main/res/values-fr/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-hi/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-hu/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused string file_exist_not, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-in/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-it/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-iw/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-ja/strings.xml Refactored string resource names, replacing abbreviations like ww with word_wrap and ww_wait with word_wrap_wait. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-pl/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-pt-rBR/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-pt/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait, improving resource clarity and consistency.
core/resources/src/main/res/values-ru/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-sv/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-ta/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-tr/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-uk/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-vi/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused string file_exist_not, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-zh-rTW/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values-zh/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.
core/resources/src/main/res/values/strings.xml Refactored string resource names, replacing abbreviations like ww_wait with word_wrap_wait and ww with word_wrap. Updated oled_desc to "Applies a pure black theme". Removed duplicate string rr and unused strings like file_exist_not and file_size, improving resource clarity and reducing redundancy.

autogenerated by presubmit.ai

github-actions[bot]
github-actions bot reviewed Oct 17, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • 1129c7c: chore(resources): refactor xml resource names and change OLED setting description
Files Processed (29)
  • core/main/src/main/java/com/rk/xededitor/ui/screens/settings/editor/SettingsEditorScreen.kt (5 hunks)
  • core/main/src/main/res/menu/menu_main.xml (1 hunk)
  • core/resources/src/main/res/values-ar/strings.xml (10 hunks)
  • core/resources/src/main/res/values-arq/strings.xml (1 hunk)
  • core/resources/src/main/res/values-bn-rIN/strings.xml (1 hunk)
  • core/resources/src/main/res/values-bn/strings.xml (1 hunk)
  • core/resources/src/main/res/values-cs/strings.xml (9 hunks)
  • core/resources/src/main/res/values-de/strings.xml (11 hunks)
  • core/resources/src/main/res/values-es/strings.xml (9 hunks)
  • core/resources/src/main/res/values-fa/strings.xml (1 hunk)
  • core/resources/src/main/res/values-fr/strings.xml (14 hunks)
  • core/resources/src/main/res/values-hi/strings.xml (10 hunks)
  • core/resources/src/main/res/values-hu/strings.xml (5 hunks)
  • core/resources/src/main/res/values-in/strings.xml (12 hunks)
  • core/resources/src/main/res/values-it/strings.xml (11 hunks)
  • core/resources/src/main/res/values-iw/strings.xml (10 hunks)
  • core/resources/src/main/res/values-ja/strings.xml (11 hunks)
  • core/resources/src/main/res/values-pl/strings.xml (12 hunks)
  • core/resources/src/main/res/values-pt-rBR/strings.xml (12 hunks)
  • core/resources/src/main/res/values-pt/strings.xml (2 hunks)
  • core/resources/src/main/res/values-ru/strings.xml (11 hunks)
  • core/resources/src/main/res/values-sv/strings.xml (7 hunks)
  • core/resources/src/main/res/values-ta/strings.xml (11 hunks)
  • core/resources/src/main/res/values-tr/strings.xml (12 hunks)
  • core/resources/src/main/res/values-uk/strings.xml (9 hunks)
  • core/resources/src/main/res/values-vi/strings.xml (5 hunks)
  • core/resources/src/main/res/values-zh-rTW/strings.xml (12 hunks)
  • core/resources/src/main/res/values-zh/strings.xml (11 hunks)
  • core/resources/src/main/res/values/strings.xml (8 hunks)
Actionable Comments (1)
  • core/resources/src/main/res/values-iw/strings.xml [126-126]

    typo: "Fix typo in Hebrew translation for unknown error."

Skipped Comments (0)

core/resources/src/main/res/values-iw/strings.xml
<string name="cursor_anim">אנימציית עכבר</string>
<string name="diagonal_scroll">גלילה אלכסונית</string>
<string name="u_err">שגיאה לא ידועה ץ</string>
<string name="unknown_error">שגיאה לא ידועה ץ</string>
Copy link

@github-actions github-actions bot Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be an extra character ץ at the end of the unknown_error string. Please remove it for correctness.

Copy link
Member Author

@KonerDev KonerDev Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be the task of the translator

@RohitKushvaha01 RohitKushvaha01 merged commit 40a0b45 into Xed-Editor:main Oct 17, 2025
@KonerDev KonerDev deleted the chore/improve-strings branch October 19, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KonerDev @RohitKushvaha01