feat(bottom-sheet): use ModalBottomSheet instead of dialog #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR SummaryReplaced the Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 4a0301a: feat(bottom-sheet): use ModalBottomSheet instead of dialog
Files Processed (4)
- core/main/src/main/java/com/rk/compose/filetree/Drawer.kt (3 hunks)
- core/main/src/main/java/com/rk/xededitor/ui/components/AddDialogItem.kt (1 hunk)
- core/main/src/main/java/com/rk/xededitor/ui/components/FileActionDialog.kt (8 hunks)
- core/main/src/main/java/com/rk/xededitor/ui/components/GlobalActions.kt (3 hunks)
Actionable Comments (2)
-
core/main/src/main/java/com/rk/xededitor/ui/components/FileActionDialog.kt [109-110]
possible bug: "Avoid using nullable static instances with '!!'."
-
core/main/src/main/java/com/rk/xededitor/ui/components/FileActionDialog.kt [184-185]
possible bug: "Redundant or incorrect state update before dismissal."
Skipped Comments (0)
core/main/src/main/java/com/rk/xededitor/ui/components/FileActionDialog.kt
Show resolved
Hide resolved
core/main/src/main/java/com/rk/xededitor/ui/components/FileActionDialog.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
XedDialogfor certain actions with theModalBottomSheet.Why this is better:
This is also used in AndroidIDE.
Screenshots