Skip to content

Conversation

@KonerDev
Copy link
Member

Code changes

  • Rename InputDialog to SingleInputDialog to emphasize that the dialog only has one input and can't be used for e.g., the LSP port prompt
  • Refactor some dialog occurrences to use the InputDialog
  • Add onFinish lambda that runs if the user either confirms or cancels (instead of how it was before: the on dismiss lambda would be also called on confirm which is non-intuitive)
  • No longer allow user to write newlines in certain dialogs like the rename dialog

UI changes

  • Make the dialogs Material Design conform
  • Split new folder and file actions into seperate dialog items
    • Add proper icons
  • Add error detection for invalid file or folder names
  • Allow user to chain folder names for nested folder creation (uses mkdirs())

Language changes

Warning

I'm not sure if I did the icons right, though. All existing custom Xed-Editor icons have a viewport width of 960f, but my icon, which I simply copied from the material icons extended library, has a viewport width of 24f. Is that a problem?

@RohitKushvaha01
Copy link
Member

[!WARNING]
I'm not sure if I did the icons right, though. All existing custom Xed-Editor icons have a viewport width of 960f, but my icon, which I simply copied from the material icons extended library, has a viewport width of 24f. Is that a problem?

Viewport size doesn't matter

@RohitKushvaha01 RohitKushvaha01 merged commit fe06390 into Xed-Editor:main Oct 1, 2025
@KonerDev KonerDev deleted the fix/improve-dialogs branch October 1, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants