fix(ui): improve dialogs and error handling #855
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
InputDialogtoSingleInputDialogto emphasize that the dialog only has one input and can't be used for e.g., the LSP port promptInputDialogonFinishlambda that runs if the user either confirms or cancels (instead of how it was before: the on dismiss lambda would be also called on confirm which is non-intuitive)UI changes
mkdirs())Language changes
FileTypetoWrapper typelike suggested in refactor(strings): replace hardcoded strings with XML resources #793 (comment)File infotoPropertiesbecause the folder properties can also be openedWarning
I'm not sure if I did the icons right, though. All existing custom Xed-Editor icons have a viewport width of
960f, but my icon, which I simply copied from the material icons extended library, has a viewport width of24f. Is that a problem?