Skip to content

feat(settings): increase text size/zoom and implement proper error messages #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RohitKushvaha01 merged 6 commits into from
Sep 29, 2025
Merged

feat(settings): increase text size/zoom and implement proper error messages #844

RohitKushvaha01 merged 6 commits into from
Sep 29, 2025

Conversation

@KonerDev
Copy link
Member

@KonerDev KonerDev commented Sep 26, 2025 •
edited
Loading

Changes

  • Change min text size from 8 to 6
  • Change max text size from 32 to 100 (the same value as in vscode)
  • Set pinch zoom factor to the same values
  • Implement error support for the InputDialog
  • Show errors in input field instead of toast messages
  • Reset value after clicking on Cancel

Closes #671 (I did not implement the zoom factor percentage number because I think that's not important)

RohitKushvaha01
RohitKushvaha01 requested changes Sep 28, 2025
View reviewed changes
Copy link
Member

@RohitKushvaha01 RohitKushvaha01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extended Icons library will increase the app size too much

@KonerDev
Copy link
Member Author

KonerDev commented Sep 28, 2025

Extended Icons library will increase the app size too much

Why don't we simply set isMinifyEnabled and isShrinkResources to true? This will automatically remove all unused resources, such as unnecessary icons. In my tests, the app size with the library and this value would actually be smaller than without both.

Xed-Editor/app/build.gradle.kts

Lines 64 to 66 in 328d359

isMinifyEnabled = false
isCrunchPngs = false
isShrinkResources = false

@RohitKushvaha01
Copy link
Member

RohitKushvaha01 commented Sep 28, 2025

Extended Icons library will increase the app size too much

Why don't we simply set isMinifyEnabled and isShrinkResources to true? This will automatically remove all unused resources, such as unnecessary icons. In my tests, the app size with the library and this value would actually be smaller than without both.

Xed-Editor/app/build.gradle.kts

Lines 64 to 66 in 328d359

isMinifyEnabled = false
isCrunchPngs = false
isShrinkResources = false

Enabling minification causes issues, and sora editor doesn't behave well

@KonerDev
Copy link
Member Author

KonerDev commented Sep 28, 2025

Extended Icons library will increase the app size too much

Why don't we simply set isMinifyEnabled and isShrinkResources to true? This will automatically remove all unused resources, such as unnecessary icons. In my tests, the app size with the library and this value would actually be smaller than without both.

Xed-Editor/app/build.gradle.kts

Lines 64 to 66 in 328d359

isMinifyEnabled = false
isCrunchPngs = false
isShrinkResources = false

Enabling minification causes issues, and sora editor doesn't behave well

Why don't you just add Proguard rules to solve the issues?

If that's not possible, we could simply add this error drawable manually.

@RohitKushvaha01 RohitKushvaha01 merged commit f69263f into Xed-Editor:main Sep 29, 2025
@KonerDev KonerDev deleted the feature/improve-settings branch October 1, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RohitKushvaha01 RohitKushvaha01 Awaiting requested review from RohitKushvaha01

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dynamic (pinch) zoom factor expected much larger

2 participants

@KonerDev @RohitKushvaha01