refactor(strings): replace hardcoded strings with XML resources #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohitKushvaha01
approved these changes
Sep 10, 2025
Member
|
FileType represents a wrapper class: native files use FileWrapper, and files accessed through SAF use UriWrapper. Sometimes it's important to know which type we're working with, since they behave a little differently. |
Member
Author
Maybe we should then rename it to e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces hardcoded strings in the file action dialog with references to the appropriate XML string resources. This improves localization support.
Changes:
ask_delto use placeholders (as suggested in Use placeholders for some weblate strings #698)Clarification
FileTypeinfo row in the file info dialog. Why would you display the name of the file's corresponding Java class to the user? Isn't this unnecessary because theTypeinfo row already exists?file_size, it might be better to abbreviate it tosize, since all the other strings do not start withfile_either.