Skip to content

feat(core): add keybindings #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KonerDev merged 8 commits into from
Dec 26, 2025
Merged

feat(core): add keybindings #1040

KonerDev merged 8 commits into from
Dec 26, 2025

Conversation

@KonerDev
Copy link
Member

@KonerDev KonerDev commented Dec 22, 2025 •
edited
Loading

This PR closes #645 #1025

Features

  • Add settings category for keybinds customization (with saving mechanism)
    • Support for setting keybinds using software AND hardware keyboard
    • Add search by command label and keybinds
  • Keybindings conflict detection
  • Search query highlighting in command palette
  • Add centralized keybind manager for handling the keybinds
  • Add more default keybinds for already existing commands
  • Add transform to lowercase/uppercase commands
  • Allow editor keybind customization (Ctrl + A, etc.) (Keybindings customization Rosemoe/sora-editor#780)

Bug fixes

  • Remove unnecessary gap below some input fields (caused by supportingText)

Enhancements

  • Improve key handling at various locations
  • Add reset button also for toolbar actions and extra keys settings

Refactor

  • Improve command architecture by separating them into different classes (EditorCommand, GlobalCommand, ...)

Screenshots

@KonerDev KonerDev linked an issue Dec 22, 2025 that may be closed by this pull request
Some keybindings don't work #1025
Closed
@KonerDev KonerDev marked this pull request as draft December 22, 2025 22:20
@RohitKushvaha01 RohitKushvaha01 added this to the Xed-Editor v3.2.6 milestone Dec 25, 2025
@KonerDev
fix(core): fix duplicate execution of editor commands by intercepting…
1b481ed 
… default handling of sora-editor
@KonerDev
refactor(core): refactor commands into separate classes, add search q…
4ddf13d 
…uery highlighting for command palette search
@KonerDev
fix(core): fix extra keys being greyed out and improve command API
397e34e
@KonerDev
feat(core): add two commands, add keybindings conflict detection, imp…
f3e2bcd 
…rove command API, fix unnecessary gap below input fields, separate handling of editor and global keybindings
@KonerDev KonerDev marked this pull request as ready for review December 26, 2025 17:41
@KonerDev KonerDev merged commit 3628885 into Xed-Editor:main Dec 26, 2025
@KonerDev KonerDev deleted the feat/better-keybinds branch December 26, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Xed-Editor v3.2.6

Development

Successfully merging this pull request may close these issues.

Some keybindings don't work Add keybindings

2 participants

@KonerDev @RohitKushvaha01