Better infinity mode implementation#16
Merged
Merged
Conversation
yuhan6665
reviewed
Feb 12, 2024
| Type: HostTypeIP, | ||
| } | ||
| for i := 0; i < math.MaxInt; i++ { | ||
| if i%2 == 0 { |
Member
There was a problem hiding this comment.
Thanks for your code. I was thinking about using channel this way. But I was worry about grow memory too fast. Isn't all these ips not yet processed in channel taking memory?
Contributor
Author
There was a problem hiding this comment.
So it's an unbuffered channel for hostChan. It will block at the sending action until a scanning goroutine picks one away from it. Not consuming memory more than 1 Host instance.
Member
There was a problem hiding this comment.
I understand now. It is indeed better. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a better infinity mode implementation using channels instead of mutex locks.
Please take a look. Really appreciated for all your works :)