Draft
Conversation
Co-authored-by: Ed Hennis <ed@ripple.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This change adds `cmake-format` as. a pre-commit hook. The style file closely matches that in Clio, and they will be made to be equivalent over time. For now, some files have been excluded, as those need some manual adjustments, which will be done in future changes.
This updates the hashes of all XRPLF/actions to their latest versions.
When support was added for `xrpld.cfg` in addition to `rippled.cfg` in #6098, as part of an effort to rename occurrences of ripple(d) to xrpl(d), the clearing and creation of the data directory were modified for what, at the time, seemed to result in an equivalent code flow. This has turned out to not be true, which is why this change restores two modifications to `Config.cpp` that currently break running the binary in standalone mode.
9 tasks
Co-authored-by: ximinez <6757714+ximinez@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix cache removal and assertion behavior based on feedback
Remove incorrect assertion in fetchBatch
Feb 3, 2026
|
This PR has conflicts, please resolve them in order for the PR to be reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Removes an incorrect assertion that assumed
fetchBatchresults size matches input hash count. The assertion fails forNullBackendwhich intentionally returns an empty vector.Context of Change
The assertion was added in commit 4495952 based on a misunderstanding of move assignment semantics:
Move assignment replaces the entire vector, ignoring any initial size. The original code never pre-sized
results, so the assertion assumption was invalid.Production backends (
MemoryFactory,RocksDBFactory,NuDBFactory) do returnresults.size() == hashes.size(), butNullBackendreturns an empty vector by design. The assertion breaks for this valid implementation.Type of Change
API Impact
None.
Before / After
Before:
After:
Restores original behavior before the assertion was introduced.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.