Skip to content

Enable fixAMMClawbackRounding#5750

Merged
Bronek merged 6 commits intoXRPLF:developfrom
yinyiqian1:enableFixAMMClawback
Sep 9, 2025
Merged

Enable fixAMMClawbackRounding#5750
Bronek merged 6 commits intoXRPLF:developfrom
yinyiqian1:enableFixAMMClawback

Conversation

@yinyiqian1
Copy link
Copy Markdown
Collaborator

@yinyiqian1 yinyiqian1 commented Sep 1, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@yinyiqian1 yinyiqian1 requested a review from a team September 1, 2025 15:33
@yinyiqian1 yinyiqian1 mentioned this pull request Sep 1, 2025
Merged
13 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.7%. Comparing base (bcde279) to head (bacd02b).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5750     +/-   ##
=========================================
- Coverage     78.7%   78.7%   -0.0%     
=========================================
  Files          816     816             
  Lines        71924   71925      +1     
  Branches      8488    8464     -24     
=========================================
- Hits         56637   56631      -6     
- Misses       15287   15294      +7

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yinyiqian1 yinyiqian1 requested a review from Bronek September 1, 2025 16:53
@yinyiqian1 yinyiqian1 requested a review from ximinez September 4, 2025 16:47
@yinyiqian1 yinyiqian1 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Sep 5, 2025
@Bronek Bronek enabled auto-merge (squash) September 5, 2025 15:15
@ximinez ximinez added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Sep 8, 2025
@Bronek Bronek merged commit f1eaa6a into XRPLF:develop Sep 9, 2025
25 checks passed
@oeggert oeggert mentioned this pull request Oct 23, 2025
Merged
@yinyiqian1 yinyiqian1 deleted the enableFixAMMClawback branch January 30, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bronek Bronek Bronek approved these changes

@ximinez ximinez Awaiting requested review from ximinez

Assignees

No one assigned

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yinyiqian1 @Bronek @ximinez