Merged
Conversation
Collaborator
|
Should the directory be named "simulate"? |
Collaborator
Author
Oops, copy-paste error - thanks! |
mDuo13
reviewed
Aug 16, 2024
Collaborator
mDuo13
left a comment
There was a problem hiding this comment.
I've only worked my way through about half the spec so far but it mostly looks good. I've added a few comments where clarifications or rephrasing would be helpful.
mDuo13
reviewed
Aug 16, 2024
mDuo13
reviewed
Aug 19, 2024
3 tasks
ckeshava
reviewed
Sep 6, 2024
ckeshava
reviewed
Sep 9, 2024
Collaborator
Author
|
@sappenin this is ready to merge. The remaining open questions will be addressed in future PRs. |
sappenin
approved these changes
Sep 11, 2024
ckeshava
reviewed
Oct 14, 2024
tequdev
reviewed
Nov 13, 2024
|
|
||
| ## 9. RPC: `deposit_authorized` | ||
|
|
||
| The [`deposit_authorized` RPC method](https://xrpl.org/deposit_authorized.html) already exists on the XRPL. This proposal suggests some modifications to also support credential authorization. |
Member
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
The link still redirects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion thread can be found here: #202