Merged
Conversation
13 tasks
Contributor
|
I think we may want to consider changing/updating this to use the API version 2 format. (Unrelated: Outside the scope of this spec, I noticed the docs have not yet been updated for API version 2, so I opened this: XRPLF/xrpl-dev-portal#2693) |
Collaborator
Author
Is there some part of the spec that doesn't use the APIv2 format? I thought I got everything. |
mvadari
commented
Jul 23, 2024
Contributor
|
I think the Example Response should be updated to have the transaction data moved under |
Collaborator
Author
It already is. I've made some changes to this version that aren't in the discussion, btw. |
intelliot
approved these changes
Jul 31, 2024
Collaborator
Author
|
@sappenin this is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion thread can be found here: #199