XLS-33d: Compact Fungible Tokens (CFTs)#109
Merged
intelliot merged 7 commits intoXRPLF:masterfrom Jun 22, 2023
Merged
Conversation
sappenin
requested changes
May 17, 2023
sappenin
reviewed
May 18, 2023
sappenin
reviewed
May 18, 2023
sappenin
reviewed
May 18, 2023
sappenin
reviewed
May 18, 2023
intelliot
approved these changes
May 20, 2023
Collaborator
|
+1 to all of the changes proposed by @intelliot (I can't merge them though). :) |
sappenin
reviewed
May 22, 2023
sappenin
reviewed
May 22, 2023
sappenin
reviewed
May 22, 2023
Silkjaer
reviewed
May 25, 2023
Contributor
Silkjaer
left a comment
There was a problem hiding this comment.
A few fixes needed before it can be merged :)
shawnxie999
reviewed
May 30, 2023
shawnxie999
reviewed
May 30, 2023
shawnxie999
reviewed
May 30, 2023
shawnxie999
reviewed
May 30, 2023
shawnxie999
reviewed
May 30, 2023
shawnxie999
reviewed
May 30, 2023
shawnxie999
reviewed
May 30, 2023
Contributor
|
@ledhed2222 please respond to the above comments, at your convenience |
Contributor
Author
|
@intelliot done :) |
intelliot
approved these changes
Jun 7, 2023
shawnxie999
approved these changes
Jun 7, 2023
sappenin
approved these changes
Jun 14, 2023
Collaborator
|
@Silkjaer - all requested changes have been merged by @ledhed2222. Once you give a final approval I'll go ahead and merge this one. |
Closed
Contributor
Author
|
@Silkjaer hey there! can you review again please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: This PR has been merged and the XLS-33d spec can be viewed here.
Please feel free to open a new PR to propose any changes or updates to the spec.
Initial commit of XLS-33d spec
Per
CONTRIBUTING.md- this is ready to merge as a draft spec. The spec will continue to be updated with new PRs after this!