Criteria cleanup #1572

mambax7 · 2025-09-09T08:56:43Z

No description provided.

Copilot

Pull Request Overview

A comprehensive refactoring to update database quoting method calls from the deprecated quoteString() method to the modern quote() method across the XOOPS codebase. This improves consistency with current database abstraction standards.

Updates all instances of $db->quoteString() to $db->quote() across core files
Adds deprecation warnings and modern database API improvements
Implements enhanced security for LIKE patterns with wildcard escaping

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
htdocs/modules/system/class/block.php	Updates database quoting method call
htdocs/modules/profile/edituser.php	Updates database quoting method call
htdocs/kernel/tplset.php	Updates multiple database quoting method calls in template set handlers
htdocs/kernel/tplfile.php	Updates database quoting method calls in template file operations
htdocs/kernel/session.php	Updates database quoting method calls in session management
htdocs/kernel/privmessage.php	Updates database quoting method calls in private message operations
htdocs/kernel/notification.php	Updates database quoting method calls in notification system
htdocs/kernel/module.php	Updates database quoting method calls in module management
htdocs/kernel/imagesetimg.php	Updates database quoting method calls in image set operations
htdocs/kernel/imageset.php	Updates database quoting method calls in image set management
htdocs/kernel/imagecategory.php	Updates database quoting method calls in image category operations
htdocs/kernel/image.php	Updates database quoting method calls in image operations
htdocs/kernel/groupperm.php	Updates database quoting method call in group permissions
htdocs/kernel/group.php	Updates database quoting method calls in group management
htdocs/kernel/configitem.php	Updates database quoting method calls in configuration item operations
htdocs/kernel/configcategory.php	Updates database quoting method calls in configuration category operations
htdocs/kernel/comment.php	Updates database quoting method calls in comment system
htdocs/kernel/block.php	Updates database quoting method call in block operations
htdocs/kernel/avatar.php	Updates database quoting method calls in avatar management
htdocs/include/findusers.php	Updates database quoting method call in user finder
htdocs/edituser.php	Updates database quoting method call in user editing
htdocs/class/xoopseditor/tinymce/tinymce/jscripts/tiny_mce/plugins/xoopsemotions/xoopsemotions.php	Updates database quoting method calls in emotions plugin
htdocs/class/module.textsanitizer.php	Updates deprecation message text
htdocs/class/model/joint.php	Updates database quoting method call in joint model operations
htdocs/class/database/mysqldatabase.php	Implements new quote() method and deprecation handling for quoteString()
htdocs/class/database/database.php	Adds abstract quote() method and deprecation handling
htdocs/class/criteria.php	Enhances criteria rendering with improved quoting and LIKE pattern security
htdocs/banners.php	Updates database quoting method calls in banner system

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Criteria cleanup

711a875

mambax7 requested a review from Copilot September 9, 2025 08:57