Hide empty userinfo value #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the user interface by conditionally displaying user profile fields only when they contain data, preventing empty fields from appearing in the user information display.
- Wraps user profile field assignments in conditional checks to prevent empty values from being displayed
- Removes unnecessary empty string assignment for website URL when the field is empty
- Adds consistent conditional logic across all optional profile fields (name, website, ICQ, AIM, YIM, MSN, location, occupation, interests, bio, signature)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+136
to
+138
| if ($thisUser->getVar('user_intrest') != '') { | ||
| $xoopsTpl->assign('lang_interest', _US_INTEREST); | ||
| $xoopsTpl->assign('user_interest', $thisUser->getVar('user_intrest')); |
There was a problem hiding this comment.
There's a spelling inconsistency: the database field is 'user_intrest' but the template variable is 'user_interest'. The field name should likely be 'user_interest' to match the correct spelling.
Suggested change
| if ($thisUser->getVar('user_intrest') != '') { | |
| $xoopsTpl->assign('lang_interest', _US_INTEREST); | |
| $xoopsTpl->assign('user_interest', $thisUser->getVar('user_intrest')); | |
| if ($thisUser->getVar('user_interest') != '') { | |
| $xoopsTpl->assign('lang_interest', _US_INTEREST); | |
| $xoopsTpl->assign('user_interest', $thisUser->getVar('user_interest')); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fix:#1561)