Fix Deprecated addSlashes #1566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces deprecated addSlashes() function calls with the proper $xoopsDB->escape() method across multiple files in the XOOPS CMS core. The deprecated addSlashes() function from the MyTextSanitizer class is being replaced with the database-specific escaping method to improve security and follow modern practices.
Key changes:
- Replace
$myts->addSlashes()calls with$xoopsDB->escape()for proper SQL escaping - Remove unused
$mytsvariable declarations where they're no longer needed - Add
global $xoopsDB;declarations where the database object wasn't previously accessible
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| htdocs/search.php | Replace addSlashes with escape for search query sanitization |
| htdocs/modules/system/admin/users/main.php | Replace addSlashes with escape for email validation |
| htdocs/modules/profile/search.php | Replace addSlashes with escape and remove unused $myts variable |
| htdocs/modules/profile/lostpass.php | Replace addSlashes with escape and remove unused $myts variable |
| htdocs/modules/profile/edituser.php | Replace addSlashes with escape for avatar handling |
| htdocs/modules/profile/activate.php | Replace addSlashes with escape for email handling |
| htdocs/lostpass.php | Replace addSlashes with escape for password recovery |
| htdocs/edituser.php | Replace addSlashes with escape for user avatar processing |
| htdocs/class/xoopstopic.php | Replace addSlashes with escape and update variable declarations |
| htdocs/class/xoopsstory.php | Replace addSlashes with escape for story content handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this point:
#1564
Xoops should not use the deprecated ‘addSlashes’ function in its core.
This PR fixes this error.