Fix: https://github.com/XOOPS/XoopsCore25/issues/1564 #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures backward compatibility while signaling to developers that they should migrate to safer, modern methods for SQL escaping.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #1564 by restoring the actual SQL escaping functionality to the deprecated addSlashes() method while maintaining the deprecation warning. The change ensures backward compatibility for legacy code that still relies on this method while encouraging migration to modern alternatives.
- Restored SQL escaping functionality using
$xoopsDB->escape()instead of returning unescaped text - Enhanced deprecation message to suggest specific modern alternatives
- Added global database connection reference for escaping functionality
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| { | ||
| $GLOBALS['xoopsLogger']->addDeprecated(__METHOD__ . ' is deprecated'); | ||
| return $text; | ||
| global $xoopsDB; |
There was a problem hiding this comment.
Using a global variable for database access without null checking could lead to fatal errors if $xoopsDB is not initialized. Add a null check and appropriate error handling before calling $xoopsDB->escape().
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures backward compatibility while signaling to developers that they should migrate to safer, modern methods for SQL escaping.